From 0975fa1fd4eab8a71d1ba7c8f6788aa445054a18 Mon Sep 17 00:00:00 2001 From: Polochon-street Date: Thu, 1 Jul 2021 21:29:48 +0200 Subject: [PATCH] Add an `analyze_paths_streaming` function --- CHANGELOG.md | 3 ++ Cargo.lock | 2 +- Cargo.toml | 2 +- src/lib.rs | 2 +- src/library.rs | 109 ++++++++++++++++++++++++++++++++++++++++++++++++- src/song.rs | 4 +- 6 files changed, 116 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3800ef4..4baf6b0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Changelog +## bliss 0.3.3 +* Add a streaming analysis function, to help libraries displaying progress. + ## bliss 0.3.2 * Fixed a rare ffmpeg multithreading bug. diff --git a/Cargo.lock b/Cargo.lock index 4436fdf..abd6d80 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -75,7 +75,7 @@ checksum = "cf1de2fe8c75bc145a2f577add951f8134889b4795d47466a54a5c846d691693" [[package]] name = "bliss-audio" -version = "0.3.2" +version = "0.3.3" dependencies = [ "bliss-audio-aubio-rs", "crossbeam", diff --git a/Cargo.toml b/Cargo.toml index 41a2e7a..391065e 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "bliss-audio" -version = "0.3.2" +version = "0.3.3" authors = ["Polochon-street "] edition = "2018" license = "GPL-3.0-only" diff --git a/src/lib.rs b/src/lib.rs index ec0d20c..bf8ea63 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -66,7 +66,7 @@ #![warn(missing_doc_code_examples)] mod chroma; pub mod distance; -mod library; +pub mod library; mod misc; mod song; mod temporal; diff --git a/src/library.rs b/src/library.rs index c8a1472..e2f8858 100644 --- a/src/library.rs +++ b/src/library.rs @@ -1,5 +1,8 @@ //! Module containing the Library trait, useful to get started to implement //! a plug-in for an audio player. +//! +//! Looking at the [reference implementation for +//! MPD](https://github.com/Polochon-street/blissify-rs) could also be useful. #[cfg(doc)] use crate::distance; use crate::distance::DistanceMetric; @@ -116,7 +119,7 @@ pub trait Library { /// Analyze and store songs in `paths`, using `store_song` and /// `store_error_song` implementations. /// - /// Note: this is mostly useful for updating a song library. For the first + /// note: this is mostly useful for updating a song library. for the first /// run, you probably want to use `analyze_library`. fn analyze_paths(&mut self, paths: Vec) -> BlissResult<()> { if paths.is_empty() { @@ -192,6 +195,82 @@ pub trait Library { self.analyze_paths(paths)?; Ok(()) } + + /// Analyze an entire library using `get_songs_paths`, but instead of + /// storing songs using [store_song](Library::store_song) + /// and [store_error_song](Library::store_error_song). + /// + /// Returns an iterable [Receiver], whose items are a tuple made of + /// the song path (to display to the user in case the analysis failed), + /// and a Result. + fn analyze_library_streaming(&mut self) -> BlissResult)>> { + let paths = self + .get_songs_paths() + .map_err(|e| BlissError::ProviderError(e.to_string()))?; + analyze_paths_streaming(paths) + } +} + +/// Analyze songs in `paths`, and return the analyzed [Song] objects through a +/// [Receiver]. +/// +/// Returns an iterable [Receiver], whose items are a tuple made of +/// the song path (to display to the user in case the analysis failed), +/// and a Result. +/// +/// Note: this is mostly useful for updating a song library, while displaying +/// status to the user (since you have access to each song object). For the +/// first run, you probably want to use `analyze_library`. +/// +/// * Example: +/// ```no_run +/// use bliss_audio::{library::analyze_paths_streaming, BlissResult}; +/// +/// fn main() -> BlissResult<()> { +/// let paths = vec![String::from("/path/to/song1"), String::from("/path/to/song2")]; +/// let rx = analyze_paths_streaming(paths)?; +/// for (path, result) in rx.iter() { +/// match result { +/// Ok(song) => println!("Do something with analyzed song {} with title {:?}", song.path.display(), song.title), +/// Err(e) => println!("Song at {} could not be analyzed. Failed with: {}", path, e), +/// } +/// } +/// Ok(()) +/// } +/// ``` +pub fn analyze_paths_streaming( + paths: Vec, +) -> BlissResult)>> { + let num_cpus = num_cpus::get(); + + #[allow(clippy::type_complexity)] + let (tx, rx): ( + Sender<(String, BlissResult)>, + Receiver<(String, BlissResult)>, + ) = mpsc::channel(); + if paths.is_empty() { + return Ok(rx); + } + let mut handles = Vec::new(); + let mut chunk_length = paths.len() / num_cpus; + if chunk_length == 0 { + chunk_length = paths.len(); + } + + for chunk in paths.chunks(chunk_length) { + let tx_thread = tx.clone(); + let owned_chunk = chunk.to_owned(); + let child = thread::spawn(move || { + for path in owned_chunk { + info!("Analyzing file '{}'", path); + let song = Song::new(&path); + tx_thread.send((path.to_string(), song)).unwrap(); + } + }); + handles.push(child); + } + + Ok(rx) } #[cfg(test)] @@ -325,6 +404,34 @@ mod test { assert!(test_library.analyze_library().is_ok()) } + #[test] + fn test_analyze_library_streaming() { + let mut test_library = TestLibrary { + internal_storage: vec![], + failed_files: vec![], + }; + let rx = test_library.analyze_library_streaming().unwrap(); + + let mut result = rx.iter().collect::)>>(); + result.sort_by_key(|k| k.0.to_owned()); + let expected = result + .iter() + .map(|x| match &x.1 { + Ok(s) => (true, s.path.to_string_lossy().to_string()), + Err(_) => (false, x.0.to_owned()), + }) + .collect::>(); + assert_eq!( + vec![ + (true, String::from("./data/s16_mono_22_5kHz.flac")), + (true, String::from("./data/white_noise.flac")), + (false, String::from("definitely-not-existing.foo")), + (false, String::from("not-existing.foo")), + ], + expected, + ); + } + #[test] fn test_analyze_library() { let mut test_library = TestLibrary { diff --git a/src/song.rs b/src/song.rs index 6bb69fc..abc4128 100644 --- a/src/song.rs +++ b/src/song.rs @@ -466,7 +466,7 @@ impl Song { song.sample_array = child.join().unwrap()?; return Ok(song); } - Err(e) => warn!("decoding error: {}", e), + Err(e) => warn!("error while decoding {}: {}", path.display(), e), }; loop { @@ -500,7 +500,7 @@ impl Song { song.sample_array = child.join().unwrap()?; return Ok(song); } - Err(e) => warn!("decoding error: {}", e), + Err(e) => warn!("error while decoding {}: {}", path.display(), e), }; loop {