support for Aokzoe/ OXP mini pro 6800u devices #9

Open
opened 1 year ago by NikhilSaini38 · 3 comments
NikhilSaini38 commented 1 year ago (Migrated from github.com)

Hi, i have been testing oxp-sensors with the respective module's author and its functional in my AOKZOE device, Fantastic is able to read the fan speed, but cannot implement custom curves. I am currently on holoiso 3.4. Any possibility for support to be added?

Hi, i have been testing [oxp-sensors](https://github.com/samsagax/oxp-platform-dkms) with the respective module's author and its functional in my AOKZOE device, Fantastic is able to read the fan speed, but cannot implement custom curves. I am currently on holoiso 3.4. Any possibility for support to be added?
NGnius commented 1 year ago (Migrated from github.com)

I don't currently have any other devices to test on, so that's the primary limiting factor for me supporting other devices. Of course if someone else makes a PR, or I can get my hands on a device, then I'll be happy to merge/add support.

I don't currently have any other devices to test on, so that's the primary limiting factor for me supporting other devices. Of course if someone else makes a PR, or I can get my hands on a device, then I'll be happy to merge/add support.
NikhilSaini38 commented 1 year ago (Migrated from github.com)

I don't currently have any other devices to test on, so that's the primary limiting factor for me supporting other devices. Of course if someone else makes a PR, or I can get my hands on a device, then I'll be happy to merge/add support.

I have the device and can help develop, i have no prior rust experience so not sure what my code quality would be. What i've gathered we need to override fan control in sys.rs through /sys/class/hwmon/hwmon?/pwm1_enable which when set to 1 enables manual fan control and auto on 0.

Similarly /sys/class/hwmon/hwmon?/pwm1 controls fan speed it takes values 0-255 the.

On EC level oxp-mini-pro takes 0-100 values for fan speed control and aokzoe takes 0-255 but this is handled by the driver i mentioned,so fantastic only needs to target values 0-255.

The driver is hopefully going to be merged in kernel 6.2 and backported, a previous version for older oxp devices has already been merged in hwmon-next for kernel 6.1

We might need device specific overrides using DMI strings to select what config to apply.

One caveat is that device i currently have shows some default value of 2000 in /sys/class/thermal/thermal_zone0/temp i am trying to see what can be done to get it fixed.

I assume we wouldnt be able to fully implement fantastic without that. Maybe target amdgpu or aggregate temps while in development? Since they are in same package.

Also have you considered using fancontrold backend?

> I don't currently have any other devices to test on, so that's the primary limiting factor for me supporting other devices. Of course if someone else makes a PR, or I can get my hands on a device, then I'll be happy to merge/add support. I have the device and can help develop, i have no prior rust experience so not sure what my code quality would be. What i've gathered we need to override fan control in `sys.rs` through `/sys/class/hwmon/hwmon?/pwm1_enable` which when set to 1 enables manual fan control and auto on 0. Similarly `/sys/class/hwmon/hwmon?/pwm1` controls fan speed it takes values 0-255 the. On EC level oxp-mini-pro takes 0-100 values for fan speed control and aokzoe takes 0-255 but this is handled by the driver i mentioned,so fantastic only needs to target values 0-255. The driver is hopefully going to be merged in kernel 6.2 and backported, a previous version for older oxp devices has already been merged in hwmon-next for kernel 6.1 We might need device specific overrides using DMI strings to select what config to apply. One caveat is that device i currently have shows some default value of 2000 in `/sys/class/thermal/thermal_zone0/temp` i am trying to see what can be done to get it fixed. I assume we wouldnt be able to fully implement fantastic without that. Maybe target amdgpu or aggregate temps while in development? Since they are in same package. Also have you considered using fancontrold backend?
Samsagax commented 1 year ago (Migrated from github.com)

I don't currently have any other devices to test on, so that's the primary limiting factor for me supporting other devices. Of course if someone else makes a PR, or I can get my hands on a device, then I'll be happy to merge/add support.

I can help with that... I'm working in a "general" fanc ontroller that would read/write to the sysfs hwmon exposes. I'm in the middle of it, but maybe we can join forces to leverage this project instead.

The main issue I think is making the interface generic to be able to control any pwm/fan the user chooses with any sensor (or combination of them, maybe) he chooses.

I'm not well versed in Rust so maybe I need to learn it to help. But count me in for the solution.

> I don't currently have any other devices to test on, so that's the primary limiting factor for me supporting other devices. Of course if someone else makes a PR, or I can get my hands on a device, then I'll be happy to merge/add support. I can help with that... I'm working in a "general" fanc ontroller that would read/write to the sysfs hwmon exposes. I'm in the middle of it, but maybe we can join forces to leverage this project instead. The main issue I think is making the interface generic to be able to control any pwm/fan the user chooses with any sensor (or combination of them, maybe) he chooses. I'm not well versed in Rust so maybe I need to learn it to help. But count me in for the solution.
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NG-SD-Plugins/Fantastic#9
Loading…
There is no content yet.