NG-SD-Plugins/usdpl-rs
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Nodejs Compatibility #3

New issue
Open
opened 2023-04-01 13:57:17 +01:00 by CEbbinghaus · 2 comments
CEbbinghaus commented 2023-04-01 13:57:17 +01:00 (Migrated from github.com)
Copy link

Now I know this isn't a priority but it would be nice if lines 45-46 in usdpl-front/src/connection.rs
91149f9dfc/usdpl-front/src/connection.rs (L45-L46)
could be changed to not rely on the "window" object but instead, just call fetch directly. As such would make it possible to run from nodejs which also has a built-in fetch function.

Now I know this isn't a priority but it would be nice if lines 45-46 in usdpl-front/src/connection.rs https://github.com/NGnius/usdpl-rs/blob/91149f9dfcb59ee264b009fc97ad834f21c337cb/usdpl-front/src/connection.rs#L45-L46 could be changed to not rely on the "window" object but instead, just call fetch directly. As such would make it possible to run from nodejs which also has a built-in fetch function.
NGnius commented 2023-04-02 02:01:24 +01:00 (Migrated from github.com)
Copy link

I'm not actually sure how do that through Rust's WASM bindings, but I don't see why it wouldn't be possible.

There's a lot of technical debt in this project right now because I've only been adding to it when I need to do something fancy in a Decky plugin. With a bit of luck this will be fixed along with the refactor/rewrite for #2 ... whenever I have some motivation to do that.

I'm not actually sure how do that through Rust's WASM bindings, but I don't see why it wouldn't be possible. There's a lot of technical debt in this project right now because I've only been adding to it when I need to do something fancy in a Decky plugin. With a bit of luck this will be fixed along with the refactor/rewrite for #2 ... whenever I have some motivation to do that.
CEbbinghaus commented 2023-04-03 15:17:55 +01:00 (Migrated from github.com)
Copy link

I raised an issue in rustwasm/wasm-bindgen#3377 to add support for cross-runtime fetch support which would hopefully make it simple enough to fix this too. Until then that is the main blocker for this Issue

I raised an issue in rustwasm/wasm-bindgen#3377 to add support for cross-runtime fetch support which would hopefully make it simple enough to fix this too. Until then that is the main blocker for this Issue
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
next
No results found.
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: NG-SD-Plugins/usdpl-rs#3
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?