1
0
Fork 0
mirror of https://github.com/Atmosphere-NX/Atmosphere.git synced 2024-11-17 17:36:44 +00:00
Atmosphere/stratosphere
Léo Lam 496adb0018
Minor header fixes to reduce parsing issues with Clang (#1700)
* Work around Clang's incomplete C++20 support for omitting typename

* vapours: fix Clang error about missing return in constexpr function

* stratosphere: fix call to non-constexpr strlen in constexpr function

strlen being constexpr is a non-compliant GCC extension; Clang
explicitly rejects it: https://reviews.llvm.org/D23692

* stratosphere: add a bunch of missing override specifiers

* stratosphere: work around Clang consteval bug

Minimal example: https://godbolt.org/z/MoM64v93M

The issue seems to be that Clang does not consider f(x) to be a
constant expression if x comes from a template argument that isn't
a non-type auto template argument (???)

We can work around this by relaxing GetMessageHeaderForCheck (by using
constexpr instead of consteval). This produces no functional changes
because the result of GetMessageHeaderForCheck() is assigned to a
constexpr variable, so the result is guaranteed to be computed
at compile-time.

* stratosphere: fix missing require clauses in definitions

GCC not requiring the require clauses to be repeated for member
definitions is actually a compiler bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96830

Clang rejects declarations with missing require clauses.

* Fix ALWAYS_INLINE_LAMBDA and parameter list relative order

While GCC doesn't seem to care about the position of the always_inline
attribute relative to the parameter list, Clang is very picky
and requires the attribute to appear after the parameter list
(and before a trailing return type)

* stratosphere: fix static constexpr member variable with incomplete type

GCC accepts this for some reason (because of the lambda?) but Clang
correctly rejects this.
2021-11-06 18:19:34 -07:00
..
ams_mitm Minor header fixes to reduce parsing issues with Clang (#1700) 2021-11-06 18:19:34 -07:00
boot boot: update for 13.0.0/aula parameter changes (closes #1477) 2021-10-15 19:03:11 -07:00
boot2 strat: use ams::Main() instead of main(argc, argv) 2021-10-07 17:44:54 -07:00
creport creport: fix errant ) 2021-11-03 23:56:25 -07:00
cs strat: use ams::Main() instead of main(argc, argv) 2021-10-07 17:44:54 -07:00
dmnt dmnt2: first pass at wait-for-application 2021-11-03 23:56:25 -07:00
dmnt.gen2 dmnt2: fix gdb register output 2021-11-03 23:56:25 -07:00
eclct.stub strat: use ams::Main() instead of main(argc, argv) 2021-10-07 17:44:54 -07:00
erpt strat: use ams::Main() instead of main(argc, argv) 2021-10-07 17:44:54 -07:00
fatal fatal: use align up for width calc 2021-10-11 12:41:43 -07:00
htc strat: use ams::Main() instead of main(argc, argv) 2021-10-07 17:44:54 -07:00
jpegdec jpegdec: save 128KB of memory 2021-10-07 18:03:11 -07:00
loader sf: prevent emitting mitm/defer code unless server in process supports it 2021-10-11 19:01:27 -07:00
LogManager strat: use ams::Main() instead of main(argc, argv) 2021-10-07 17:44:54 -07:00
ncm sf: prevent emitting mitm/defer code unless server in process supports it 2021-10-11 19:01:27 -07:00
pgl strat: use ams::Main() instead of main(argc, argv) 2021-10-07 17:44:54 -07:00
pm sm/tipc: minor cleanup 2021-10-12 00:20:21 -07:00
ro loader: refactor ro manager/improve accuracy 2021-10-10 18:22:32 -07:00
sm Minor header fixes to reduce parsing issues with Clang (#1700) 2021-11-06 18:19:34 -07:00
spl spl: fix legacy physical keyslot compatibility 2021-10-30 11:21:25 -07:00
TioServer strat: use ams::Main() instead of main(argc, argv) 2021-10-07 17:44:54 -07:00
Makefile dmnt2: add logging logic, for use with gdbstub development 2021-09-11 19:41:47 -07:00