mirrors/citra
1
0
Fork 0
Code Issues Pull requests Releases Activity

title_metadata: Take std::vector by const reference in Load()

Browse source 
This isn't modified in the implementation, so this can be a const
reference to eliminate an unnecessary heap reallocation.
This commit is contained in:
Lioncash 2020-05-01 09:53:42 -04:00
parent 147073a5a0
commit 10a32c94b6
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core/file_sys/title_metadata.cpp
View file

@ -33,7 +33,7 @@ Loader::ResultStatus TitleMetadata::Load(const std::string& file_path) {
return result; return result;
} }
Loader::ResultStatus TitleMetadata::Load(const std::vector<u8> file_data, std::size_t offset) { Loader::ResultStatus TitleMetadata::Load(const std::vector<u8>& file_data, std::size_t offset) {
std::size_t total_size = static_cast<std::size_t>(file_data.size() - offset); std::size_t total_size = static_cast<std::size_t>(file_data.size() - offset);
if (total_size < sizeof(u32_be)) if (total_size < sizeof(u32_be))
return Loader::ResultStatus::Error; return Loader::ResultStatus::Error;

2
src/core/file_sys/title_metadata.h
View file

@ -85,7 +85,7 @@ public:
#pragma pack(pop) #pragma pack(pop)
Loader::ResultStatus Load(const std::string& file_path); Loader::ResultStatus Load(const std::string& file_path);
Loader::ResultStatus Load(const std::vector<u8> file_data, std::size_t offset = 0); Loader::ResultStatus Load(const std::vector<u8>& file_data, std::size_t offset = 0);
Loader::ResultStatus Save(const std::string& file_path); Loader::ResultStatus Save(const std::string& file_path);
u64 GetTitleID() const; u64 GetTitleID() const;