mirrors/yuzu
2
1
Fork 0
mirror of https://github.com/yuzu-emu/yuzu.git synced 2024-07-04 23:31:19 +01:00
Code Issues Releases Activity

shader_bytecode: Eliminate variable shadowing

Browse source
This commit is contained in:
Lioncash 2020-11-20 02:13:45 -05:00
parent 92344da20c
commit 56ecafc204
1 changed files with 17 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
src/video_core/engines/shader_bytecode.h
View file

@ -32,7 +32,7 @@ struct Register {
constexpr Register() = default; constexpr Register() = default;
constexpr Register(u64 value) : value(value) {} constexpr Register(u64 value_) : value(value_) {}
constexpr operator u64() const { constexpr operator u64() const {
return value; return value;
@ -75,7 +75,7 @@ enum class AttributeSize : u64 {
union Attribute { union Attribute {
Attribute() = default; Attribute() = default;
constexpr explicit Attribute(u64 value) : value(value) {} constexpr explicit Attribute(u64 value_) : value(value_) {}
enum class Index : u64 { enum class Index : u64 {
LayerViewportPointSize = 6, LayerViewportPointSize = 6,
@ -124,7 +124,7 @@ union Attribute {
union Sampler { union Sampler {
Sampler() = default; Sampler() = default;
constexpr explicit Sampler(u64 value) : value(value) {} constexpr explicit Sampler(u64 value_) : value(value_) {}
enum class Index : u64 { enum class Index : u64 {
Sampler_0 = 8, Sampler_0 = 8,
@ -137,7 +137,7 @@ union Sampler {
union Image { union Image {
Image() = default; Image() = default;
constexpr explicit Image(u64 value) : value{value} {} constexpr explicit Image(u64 value_) : value{value_} {}
BitField<36, 13, u64> index; BitField<36, 13, u64> index;
u64 value; u64 value;
@ -658,7 +658,7 @@ union Instruction {
return *this; return *this;
} }
constexpr Instruction(u64 value) : value{value} {} constexpr Instruction(u64 value_) : value{value_} {}
constexpr Instruction(const Instruction& instr) : value(instr.value) {} constexpr Instruction(const Instruction& instr) : value(instr.value) {}
constexpr bool Bit(u64 offset) const { constexpr bool Bit(u64 offset) const {
@ -1624,12 +1624,13 @@ union Instruction {
s32 GetBranchTarget() const { s32 GetBranchTarget() const {
// Sign extend the branch target offset // Sign extend the branch target offset
u32 mask = 1U << (24 - 1); const auto mask = 1U << (24 - 1);
u32 value = static_cast<u32>(target); const auto target_value = static_cast<u32>(target);
constexpr auto instruction_size = static_cast<s32>(sizeof(Instruction));
// The branch offset is relative to the next instruction and is stored in bytes, so // The branch offset is relative to the next instruction and is stored in bytes, so
// divide it by the size of an instruction and add 1 to it. // divide it by the size of an instruction and add 1 to it.
return static_cast<s32>((value ^ mask) - mask) / static_cast<s32>(sizeof(Instruction)) + return static_cast<s32>((target_value ^ mask) - mask) / instruction_size + 1;
1;
} }
} bra; } bra;
@ -1639,12 +1640,13 @@ union Instruction {
s32 GetBranchExtend() const { s32 GetBranchExtend() const {
// Sign extend the branch target offset // Sign extend the branch target offset
u32 mask = 1U << (24 - 1); const auto mask = 1U << (24 - 1);
u32 value = static_cast<u32>(target); const auto target_value = static_cast<u32>(target);
constexpr auto instruction_size = static_cast<s32>(sizeof(Instruction));
// The branch offset is relative to the next instruction and is stored in bytes, so // The branch offset is relative to the next instruction and is stored in bytes, so
// divide it by the size of an instruction and add 1 to it. // divide it by the size of an instruction and add 1 to it.
return static_cast<s32>((value ^ mask) - mask) / static_cast<s32>(sizeof(Instruction)) + return static_cast<s32>((target_value ^ mask) - mask) / instruction_size + 1;
1;
} }
} brx; } brx;
@ -2004,8 +2006,8 @@ public:
class Matcher { class Matcher {
public: public:
constexpr Matcher(const char* const name, u16 mask, u16 expected, Id id, Type type) constexpr Matcher(const char* const name_, u16 mask_, u16 expected_, Id id_, Type type_)
: name{name}, mask{mask}, expected{expected}, id{id}, type{type} {} : name{name_}, mask{mask_}, expected{expected_}, id{id_}, type{type_} {}
constexpr const char* GetName() const { constexpr const char* GetName() const {
return name; return name;