Replace pt_oc.json with universal overrides file #126

New issue

Closed

opened 2023-09-28 00:44:19 +01:00 by NGnius · 3 comments

NGnius commented

2023-09-28 00:44:19 +01:00

Owner

Please confirm

I have searched existing issues
This issue is not a duplicate of an existing one
I will fill this out to the best of my ability

Describe what you'd like to be able to do

Apply overrides to limits on other devices

This could be accomplished by removing unstable pt_oc functionality in favour of a way to override limits across all settings providers. An auxiliary file to limits_cache.json could be used to override ranges while still allowing other limits data to be updated online. The file would effectively act as an overlay for the selected limits_core::Config's limits (Vec<limits_core::Limits>).

Describe alternatives you've considered

Status quo: the unstable nature of crate::settings::steam_deck::oc_limits::OverclockLimits makes this undesirable to support, since there is no guarantee that it will remain stable between versions and users are confused when it is ignored after an update.

Integrate something like OverclockLimits into the Steam Deck enums for CPU/GPU/Battery limits in limits_core: this would still possibly be unstable and would encourage users to disable updating limits_cache.json which could leave them stuck with badly-configured limits ranges.

Anything else?

Raspberry pie is my favourite.

### Please confirm - [x] I have searched existing issues - [x] This issue is not a duplicate of an existing one - [x] I will fill this out to the best of my ability ### Describe what you'd like to be able to do Apply overrides to limits on other devices This could be accomplished by removing unstable pt_oc functionality in favour of a way to override limits across all settings providers. An auxiliary file to limits_cache.json could be used to override ranges while still allowing other limits data to be updated online. The file would effectively act as an overlay for the selected `limits_core::Config`'s `limits` (`Vec<limits_core::Limits>`). ### Describe alternatives you've considered Status quo: the unstable nature of `crate::settings::steam_deck::oc_limits::OverclockLimits` makes this undesirable to support, since there is no guarantee that it will remain stable between versions and users are confused when it is ignored after an update. Integrate something like `OverclockLimits` into the Steam Deck enums for CPU/GPU/Battery limits in `limits_core`: this would still possibly be unstable and would encourage users to disable updating limits_cache.json which could leave them stuck with badly-configured limits ranges. ### Anything else? Raspberry pie is my favourite.

NGnius added this to the Valerian milestone 2023-09-28 00:44:19 +01:00

NGnius added the

enhancement

label 2023-09-28 00:44:19 +01:00

NGnius added this to the Vacation Fun project 2023-09-28 00:44:19 +01:00

NGnius commented

2023-10-25 18:11:31 +01:00

Author

Owner

The refactor in a90932d813 completes this

The refactor in a90932d813 completes this

NGnius added the

tbr

label 2023-10-25 18:11:37 +01:00

NGnius closed this issue

2024-04-02 01:44:45 +01:00

LAEON commented

2024-05-29 17:37:29 +01:00

With the pt_oc file it was easy to change the values, but in this new version I don't understand how to do it, how do I increase the cpu/gpu and tdp frequency limit?, How can I make these modifications? where are they added?

NGnius commented

2024-05-29 21:14:06 +01:00

Author

Owner

Please refer to the wiki. If you've got specific questions, please create a new issue or use another medium to seek answers.

Please refer to the [wiki](https://git.ngni.us/NG-SD-Plugins/PowerTools/wiki/Customization). If you've got specific questions, please create a new issue or use another medium to seek answers.