NG-SD-Plugins/PowerTools
NG-SD-Plugins/PowerTools
4
4
Fork 3
Code Issues 19 Pull requests 1 Projects Releases 24 Wiki Activity

Improve AMD 6800 handheld detection #132

Merged
NGnius merged 1 commit from drokath/PowerTools:feature/improve_handheld_6800_detection into dev 2023-11-29 01:47:26 +00:00
Conversation 4 Commits 1 Files changed 4 +6 -6
drokath commented 2023-11-26 18:14:49 +00:00
Contributor
Copy link

Related to #131 tested on Aokzoe A1

Related to #131 tested on Aokzoe A1
NGnius commented 2023-11-27 14:29:00 +00:00
Owner
Copy link

Can you apply this change against the dev branch? Changes on the main branch will immediately be orphaned since dev has some changes to the file formats.

Otherwise, LGTM thanks! In the meantime, I've applied the change to the limits server so it'll be picked up next time that restarts.

Can you apply this change against the `dev` branch? Changes on the `main` branch will immediately be orphaned since `dev` has some changes to the file formats. Otherwise, LGTM thanks! In the meantime, I've applied the change to the limits server so it'll be picked up next time that restarts.
drokath changed target branch from main to dev 2023-11-28 07:24:19 +00:00
drokath force-pushed feature/improve_handheld_6800_detection from 253bd1e168 to 5b0f818323 2023-11-28 07:26:56 +00:00 Compare
drokath force-pushed feature/improve_handheld_6800_detection from 5b0f818323 to 60ad12f609 2023-11-28 07:28:28 +00:00 Compare
drokath force-pushed feature/improve_handheld_6800_detection from 60ad12f609 to 725febef50 2023-11-28 07:49:11 +00:00 Compare
drokath commented 2023-11-28 07:51:11 +00:00
Author
Contributor
Copy link

After the rebase, i was not able to get a correct device detection. also ~/.config/Powertools was not created.
Will investigate tonight.

After the rebase, i was not able to get a correct device detection. also ~/.config/Powertools was not created. Will investigate tonight.
drokath commented 2023-11-28 20:27:22 +00:00
Author
Contributor
Copy link

Okay tested (had to clean up ~/homebrew/settings/PowerTools/liimits_cache.ron) feature works as expected now.

Okay tested (had to clean up ~/homebrew/settings/PowerTools/liimits_cache.ron) feature works as expected now.
NGnius commented 2023-11-29 01:47:03 +00:00
Owner
Copy link

Sorry, I should've warned you about the file location and format changes. Looks like you figured it out though, which is wonderful. Thanks again

Sorry, I should've warned you about the file location and format changes. Looks like you figured it out though, which is wonderful. Thanks again
NGnius merged commit 8f219a3255 into dev 2023-11-29 01:47:26 +00:00
NGnius deleted branch feature/improve_handheld_6800_detection 2023-11-29 01:47:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
???

Missing information

  
bug

Something isn't working as intended

  
docs

Improvements or additions to documentation

  
enhancement

New feature or request

  
help wanted

Great for new/external code contributors

  
indev

Selected for development; coming soon

  
question

Information request

  
research

Further investigation required

  
tbr

To be released (complete)

  
wontfix

This will not be worked on

No labels
???
bug
docs
enhancement
help wanted
indev
question
research
tbr
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: NG-SD-Plugins/PowerTools#132
No description provided.
Delete branch "drokath/PowerTools:feature/improve_handheld_6800_detection"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?