Battery charge mode selection isn't being used

lukini commented

2023-09-09 19:19:18 +01:00

Please confirm

I have searched existing issues and found no duplicate
I will fill this out to the best of my ability

Extra details

I am using a custom pt_oc.json file
I am using a custom limits_cache.json file
I have submitted a log through the PowerTools UI

Expected Behaviour

The selected value for Charge Mode should be used.

Actual Behaviour

Charge Mode is actually normal, but my selected mode is still displayed.

Steps To Reproduce

Set charge mode to idle
Connect deck to charger
Watch it charge

Anything else?

I think this only happens I connect it to a charger, rather than just putting the deck to sleep. I'm not sure if it happens every time, but it happens on a weekly basis. Most days my deck is connected to a charger next to me at my desk set to idle so it shouldn't be charging the battery.

I've been having this issue for months, but finally decided to report the bug. This was claimed to be fixed here, but I'm still seeing it: #72

Also, just last month, the decky plugin used to show "current" below battery charge (Now and Max) which made it easy to see that my idle selection wasn't being adhered to, but now I either have to wait for the charge to go up to know it's charging or just preemptively change it to normal and back to idle. I'm not sure why it was removed, but it was helpful for noticing this issue.

Version

v1.4.0-rls

Platform

SteamDeck

OS

SteamOS 3 (Stable)

### Please confirm - [x] I have searched existing issues and found no duplicate - [x] I will fill this out to the best of my ability ### Extra details - [ ] I am using a custom `pt_oc.json` file - [ ] I am using a custom `limits_cache.json` file - [ ] I have submitted a log through the PowerTools UI ### Expected Behaviour The selected value for Charge Mode should be used. ### Actual Behaviour Charge Mode is actually `normal`, but my selected mode is still displayed. ### Steps To Reproduce 1. Set charge mode to `idle` 2. Connect deck to charger 3. Watch it charge ### Anything else? I *think* this only happens I connect it to a charger, rather than just putting the deck to sleep. I'm not sure if it happens every time, but it happens on a weekly basis. Most days my deck is connected to a charger next to me at my desk set to `idle` so it shouldn't be charging the battery. I've been having this issue for months, but finally decided to report the bug. This was claimed to be fixed here, but I'm still seeing it: https://git.ngni.us/NG-SD-Plugins/PowerTools/issues/72 Also, just last month, the decky plugin used to show "current" below battery charge (Now and Max) which made it easy to see that my idle selection wasn't being adhered to, but now I either have to wait for the charge to go up to know it's charging or just preemptively change it to normal and back to idle. I'm not sure why it was removed, but it was helpful for noticing this issue. ### Version v1.4.0-rls ### Platform SteamDeck ### OS SteamOS 3 (Stable)

lukini added the

bug

label 2023-09-09 19:19:18 +01:00

NGnius commented

2023-09-12 00:51:29 +01:00

Owner

Steps To Reproduce

Set charge mode to idle

Connect deck to charger

Watch it charge

I cannot reproduce this using these steps.

I think this only happens I connect it to a charger, rather than just putting the deck to sleep.

PowerTools has no effect when asleep, that isn't so much a bug as a feature of sleep (i.e. pausing all CPU work).

Also, just last month, the decky plugin used to show "current" below battery charge (Now and Max) which made it easy to see that my idle selection wasn't being adhered to, but now I either have to wait for the charge to go up to know it's charging or just preemptively change it to normal and back to idle. I'm not sure why it was removed, but it was helpful for noticing this issue.

See patch notes

> Steps To Reproduce > 1. Set charge mode to `idle` > 2. Connect deck to charger > 3. Watch it charge I cannot reproduce this using these steps. > I think this only happens I connect it to a charger, rather than just putting the deck to sleep. PowerTools has no effect when asleep, that isn't so much a bug as a feature of sleep (i.e. pausing all CPU work). > Also, just last month, the decky plugin used to show "current" below battery charge (Now and Max) which made it easy to see that my idle selection wasn't being adhered to, but now I either have to wait for the charge to go up to know it's charging or just preemptively change it to normal and back to idle. I'm not sure why it was removed, but it was helpful for noticing this issue. See [patch notes](https://git.ngni.us/NG-SD-Plugins/PowerTools/releases/tag/v1.4.0)

NGnius added the

???

label 2023-09-12 00:51:33 +01:00

lukini commented

2023-09-15 20:33:13 +01:00

Author

PowerTools has no effect when asleep, that isn't so much a bug as a feature of sleep (i.e. pausing all CPU work).

Ever since idle was added, I've been using it, even while asleep. For example, I'll plug it in, set it to idle, put it to sleep, and come back a day or 2 later with no increase in charge. I can do this repeatedly until I unplug it, take it somewhere, then return to plug it in, where this bug happens.

What I'm doing right now is I'll wake the deck, plug it in, and watch it charge even though it's set to idle. It's not asleep at all.

Should I just reinstall or do you have a better suggestion on what to do?

>PowerTools has no effect when asleep, that isn't so much a bug as a feature of sleep (i.e. pausing all CPU work). Ever since idle was added, I've been using it, even while asleep. For example, I'll plug it in, set it to idle, put it to sleep, and come back a day or 2 later with no increase in charge. I can do this repeatedly until I unplug it, take it somewhere, then return to plug it in, where this bug happens. What I'm doing right now is I'll wake the deck, plug it in, and watch it charge even though it's set to idle. It's not asleep at all. Should I just reinstall or do you have a better suggestion on what to do?

lukini commented

2023-09-16 20:12:11 +01:00

Author

Here's a quick example of it going up after plugging it in. Either it isn't actually set to idle and is showing incorrectly or the idle setting isn't being adhered to for some reason.

out.webm

3.8 MiB

NGnius commented

2023-09-17 04:04:26 +01:00

Owner

Turn off the charge limit

lukini commented

2023-09-21 17:37:49 +01:00

Author

Turn off the charge limit

I'm currently looking at my deck in the same configuration as the video after setting idle -> normal -> idle to fix the charging issue and it doesn't charge at all with the charge limit set to 80. I wouldn't expect it to since the idle setting means I don't want charge going to the battery.

Let me know if you need more info or think I should just reinstall, because it's definitely not behaving properly on my end. It feels like it's resetting to normal when I plug it in but not displaying that to me. Or PowerTools is being overridden by the OS or something like that.

> Turn off the charge limit I'm currently looking at my deck in the same configuration as the video after setting idle -> normal -> idle to fix the charging issue and it doesn't charge at all with the charge limit set to 80. I wouldn't expect it to since the idle setting means I don't want charge going to the battery. Let me know if you need more info or think I should just reinstall, because it's definitely not behaving properly on my end. It feels like it's resetting to normal when I plug it in but not displaying that to me. Or PowerTools is being overridden by the OS or something like that.

NGnius commented

2023-09-22 03:18:45 +01:00

Owner

I wouldn't expect it to since the idle setting means I don't want charge going to the battery.

I suspect we have different understandings of expected behaviour in this scenario. I see a contradiction: you've told PowerTools you want the battery to charge to 80%, but also that you don't want it to charge at all. In the case like that, the setting that's set last should take precedence, either by manual intervention or automatic triggers (plugging/unplugging, reaching that 80% battery threshold).

I'm trying to not fix this (as may be evident at this point), because the only solutions I can come up with are arbitrary and not self-evident. One option is hiding & disabling charge mode control when a battery charge limit is set. I suspect that will be a worse experience for you. Another option is to reset the charge mode or charge limit when the other is changed, which sounds even worse to me.

think I should just reinstall

Unfortunately, this will change nothing. If PowerTools starts, it's working as programmed. One of the advantages of the language and single binary distribution.

> I wouldn't expect it to since the idle setting means I don't want charge going to the battery. I suspect we have different understandings of expected behaviour in this scenario. I see a contradiction: you've told PowerTools you want the battery to charge to 80%, but also that you don't want it to charge at all. In the case like that, the setting that's set last should take precedence, either by manual intervention or automatic triggers (plugging/unplugging, reaching that 80% battery threshold). I'm trying to not fix this (as may be evident at this point), because the only solutions I can come up with are arbitrary and not self-evident. One option is hiding & disabling charge mode control when a battery charge limit is set. I suspect that will be a worse experience for you. Another option is to reset the charge mode or charge limit when the other is changed, which sounds even worse to me. > think I should just reinstall Unfortunately, this will change nothing. If PowerTools starts, it's working as programmed. One of the advantages of the language and single binary distribution.

lukini commented

2023-09-28 19:27:56 +01:00

Author

In the case like that, the setting that's set last should take precedence, either by manual intervention or automatic triggers (plugging/unplugging, reaching that 80% battery threshold).

I believe I was having this issue before I set a charge limit. I think I last touched the charge limit weeks ago, so the latest setting should always be charge mode, right? I'll give turning it off a try, though.

>In the case like that, the setting that's set last should take precedence, either by manual intervention or automatic triggers (plugging/unplugging, reaching that 80% battery threshold). I believe I was having this issue before I set a charge limit. I think I last touched the charge limit weeks ago, so the latest setting should always be charge mode, right? I'll give turning it off a try, though.

NGnius commented

2023-09-29 18:18:56 +01:00

Owner

The latest setting would likely be whatever was last set automatically, not what you set manually. Let me know how turning that off goes.

NGnius commented

2024-02-03 02:50:45 +00:00

Owner

Closing as intended behaviour

NGnius closed this issue

2024-02-03 02:50:45 +00:00

Battery charge mode selection isn't being used #124

Please confirm

Extra details

Expected Behaviour

Actual Behaviour

Steps To Reproduce

Anything else?

Version

Platform

OS