Add A Delay Profile Load Timer #129

New issue

Open

opened 2023-10-20 16:26:30 +01:00 by MarkLockwood · 1 comment

MarkLockwood commented

2023-10-20 16:26:30 +01:00

Please confirm

I have searched existing issues
This issue is not a duplicate of an existing one
I will fill this out to the best of my ability

Describe what you'd like to be able to do

So, if you're anything like me, you'll tweak and tweak until you squeeze every last drop of battery saving you can get out of PowerTools.

This is fine while the game is running, but more and more I'm starting to notice that because the profile will load alongside the game while it's opening, it's entirely possible to stall the game while it's loading if you've got some particularly aggressive changes.

It'll eventually load up just fine, but I'd love to be able to add a timed delay on applying a game's persistent profile to keep the loading times as they would be if you hadn't made any changes.

Describe alternatives you've considered

If this is too niche to be added as a feature in the future, would it be possible to pick your brain on how I'd go about adding a delay locally to your existing profile loading code? I have some experience coding, so I could probably trial-and-error my way through, but I thought I'd suggest it as an idea first. Thanks for reading this far! :)

Anything else?

No response

### Please confirm - [x] I have searched existing issues - [x] This issue is not a duplicate of an existing one - [x] I will fill this out to the best of my ability ### Describe what you'd like to be able to do So, if you're anything like me, you'll tweak and tweak until you squeeze every last drop of battery saving you can get out of PowerTools. This is fine while the game is running, but more and more I'm starting to notice that because the profile will load alongside the game while it's opening, it's entirely possible to stall the game while it's loading if you've got some particularly aggressive changes. It'll eventually load up just fine, but I'd love to be able to add a timed delay on applying a game's persistent profile to keep the loading times as they would be if you hadn't made any changes. ### Describe alternatives you've considered If this is too niche to be added as a feature in the future, would it be possible to pick your brain on how I'd go about adding a delay locally to your existing profile loading code? I have some experience coding, so I could probably trial-and-error my way through, but I thought I'd suggest it as an idea first. Thanks for reading this far! :) ### Anything else? _No response_

MarkLockwood added the

enhancement

label 2023-10-20 16:26:30 +01:00

NGnius commented

2023-11-18 22:40:03 +00:00

Owner

@not_a_segfault this might be a good first issue for you. It probably requires a change to how the API handler applies settings when they're loaded, as well as an additional persistent field (which will require changes in settings too) for saving the delay.

I'm tempted to only expose this in the back-end, since there are no native UI elements for specifying a time duration. Adding a UI element is also not so fun to do without a good understanding of a good chunk of the codebase.

@not_a_segfault this might be a good first issue for you. It probably requires a change to how the [API handler](https://git.ngni.us/NG-SD-Plugins/PowerTools/src/branch/main/backend/src/api/handler.rs#L266) applies settings when they're loaded, as well as an additional persistent field (which will require changes in settings too) for saving the delay. I'm tempted to only expose this in the back-end, since there are no native UI elements for specifying a time duration. Adding a UI element is also not so fun to do without a good understanding of a good chunk of the codebase.