Move "Reapply settings" button to the top of the PowerTools menu #158

Open
opened 2024-05-18 06:18:16 +01:00 by Aepoh · 9 comments

Describe what you'd like to be able to do

I want the "Reapply settings" button to be moved to the very top of the PowerTools menu.

Describe alternatives you've considered

Fix the bugs that stop persistent profiles from loading. This would make the "Reapply settings" button not needed to be used so regularly.

Anything else?

There is a bug that makes persistent profiles not load half the time, under various circumstances. I.e. the plugin simply does not do its job half the time. The only way for the user to resolve this is to:

  1. Notice or suspect that the PowerTools persistent profile they set for their game is not loaded.
  2. Check to confirm whether it is loaded by setting the Performance Overlay to Level 4 to ensure that the GPU/CPU are running at the specified frequencies.
  3. If they are not and PowerTools has failed to load its profile or has lost it, the user needs to scroll alllll the way down to the very bottom of the plugin menu to press the "Reapply settings" button.

I am sure the bugs regarding persistent profiles are well known, after all they've been around for quite some time. I imagine they will take some time and effort to fix, but in the meantime the irritation of those bugs can be mitigated by moving the "Reapply settings" button from the very bottom of the PowerTools menu to the very top. That shouldn't take much time or effort at all, and it would save a decent chunk of user's frustration from having to deal with PowerTools not loading or dropping their persistent profiles.

### Describe what you'd like to be able to do I want the "Reapply settings" button to be moved to the very top of the PowerTools menu. ### Describe alternatives you've considered Fix the bugs that stop persistent profiles from loading. This would make the "Reapply settings" button not needed to be used so regularly. ### Anything else? There is a bug that makes persistent profiles not load half the time, under various circumstances. I.e. the plugin simply does not do its job half the time. The only way for the user to resolve this is to: 1. Notice or suspect that the PowerTools persistent profile they set for their game is not loaded. 2. Check to confirm whether it is loaded by setting the Performance Overlay to Level 4 to ensure that the GPU/CPU are running at the specified frequencies. 3. If they are not and PowerTools has failed to load its profile or has lost it, the user needs to scroll _alllll_ the way down to the very bottom of the plugin menu to press the "Reapply settings" button. I am sure the bugs regarding persistent profiles are well known, after all they've been around for quite some time. I imagine they will take some time and effort to fix, but in the meantime the irritation of those bugs can be mitigated by moving the "Reapply settings" button from the very bottom of the PowerTools menu to the very top. That shouldn't take much time or effort at all, and it would save a decent chunk of user's frustration from having to deal with PowerTools not loading or dropping their persistent profiles.
Aepoh added the
enhancement
label 2024-05-18 06:18:16 +01:00
Owner

Fixing #144 is better than making this change to cover it up

Fixing #144 is better than making this change to cover it up
NGnius added the
wontfix
label 2024-05-20 22:59:54 +01:00
Author

Fixing #144 is better than making this change to cover it up

Yeah that’d be nice. Sounds like it would take a while, especially considering issue #144 is 3 months old at this point and it’s still not fixed and doesn’t seem to be any headway on it.
In the meantime however, it’d be nice if the button that literally gets your plugin to work for me wasn’t at the actual bottom of the menu.

> Fixing #144 is better than making this change to cover it up Yeah that’d be nice. Sounds like it would take a while, especially considering issue #144 is **3 months old** at this point and it’s still not fixed and doesn’t seem to be any headway on it. In the meantime however, it’d be nice if the button that literally gets your plugin to work for me wasn’t at the actual bottom of the menu.
Aepoh reopened this issue 2024-06-16 06:01:10 +01:00
Owner

You can change almost any other setting (and then back) to accomplish almost the same thing. You seem passionate enough about this to make the change yourself, and I'd be happy to accept a pull request with the change and make a new patch release for it (even though it's technically not a patch change). The change will be reverted in the next minor release though since that will contain a proper fix.

As it stands now, I will not be working on this change; that's what the wontfix label indicates. This is a project I do for fun, so anything inherently not fun, e.g. involving pressure or stress, I am not very interested in doing. I'll leave this issue open in case someone else wants to work on this and have the satisfaction of closing an issue by submitting a PR.

You can change almost any other setting (and then back) to accomplish almost the same thing. You seem passionate enough about this to make the change yourself, and I'd be happy to accept a pull request with the change and make a new patch release for it (even though it's technically not a patch change). The change will be reverted in the next minor release though since that will contain a proper fix. As it stands now, I will not be working on this change; that's what the `wontfix` label indicates. This is a project I do for fun, so anything inherently not fun, e.g. involving pressure or stress, I am not very interested in doing. I'll leave this issue open in case someone else wants to work on this and have the satisfaction of closing an issue by submitting a PR.
Author

I would do it myself but I’m just a simple user with no coding experience or knowledge; it’s out of my skillset. I understand that it’s not your job and you’re under no obligation to do it. It’s just a shame since to the best of my knowledge PowerTools is the only plugin that does what it does, and Valve isn’t showing any signs of natively integrating its functionality.

I would do it myself but I’m just a simple user with no coding experience or knowledge; it’s out of my skillset. I understand that it’s not your job and you’re under no obligation to do it. It’s just a shame since to the best of my knowledge PowerTools is the only plugin that does what it does, and Valve isn’t showing any signs of natively integrating its functionality.

@Aepoh incase you missed the important part:
the next minor release […] will contain a proper fix
Until then (which may never come), be patient (and appreciate what we have) taking the few seconds to reapply settings…

@NGnius is just having fun with you. There are other talented Decky Plugin devs but even they are unable to contribute, acknowledging that PowerTools is a complex Rust(y) and JavaScript beast, leaving it a “crack team of one”…
Adding a UI element is also not so fun to do without a good understanding of a good chunk of the codebase.
#129 (comment)

@Aepoh incase you missed the important part: `the next minor release […] will contain a proper fix` Until then (which may never come), be patient (and appreciate what we have) taking the few seconds to reapply settings… @NGnius is just having fun with you. There are other talented Decky Plugin devs but even they are unable to contribute, acknowledging that PowerTools is a complex Rust(y) and JavaScript beast, leaving it a “crack team of one”… `Adding a UI element is also not so fun to do without a good understanding of a good chunk of the codebase.` https://git.ngni.us/NG-SD-Plugins/PowerTools/issues/129#issuecomment-646
Owner

Adding a UI element is also not so fun to do without a good understanding of a good chunk of the codebase.

It's worth noting that that is not the case for moving UI elements. Duplicating or moving UI elements around is a strictly front-end change (i.e. only need to change some Typescript).

> Adding a UI element is also not so fun to do without a good understanding of a good chunk of the codebase. It's worth noting that that is not the case for moving UI elements. Duplicating or moving UI elements around is a strictly front-end change (i.e. only need to change some Typescript).

Consider this my “make Aepoh happy” PR v2.0.3.001:
Cut lines 506 to 516, paste at line 379:

<PanelSectionRow>

Consider this my “make Aepoh happy” PR v2.0.3.001: Cut lines 506 to 516, paste at line 379: https://git.ngni.us/NG-SD-Plugins/PowerTools/src/commit/bf7b5617b2a22f44eb5af4785439d361e7d80108/src/index.tsx#L506
Owner

At best that's a change request not a pull request 😆

At best that's a change request not a pull request 😆

Let's not argue oyer semantics
At best it's a partially correct non-request
Looking forward to the next (whenever it is) release 🤗

Let's not argue oyer semantics At **best** it's a _partially_ correct non-request Looking forward to the next (whenever it is) release 🤗
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: NG-SD-Plugins/PowerTools#158
No description provided.